Join our Newsletter — 33% off our NHI Course

What should teams do after SAST findings are discovered in pull requests or merge requests?

Teams should triage findings quickly, assign ownership, and fix the highest-risk issues before merging code into the main branch. PR and MR feedback works best when it is immediate, actionable, and tied to existing review workflows. That keeps security collaborative rather than punitive and prevents known weaknesses from moving downstream.

How SAST Findings Should Move Through Pull Request Review

SAST findings discovered in pull requests or merge requests should be treated as review-stage signals, not as post-merge surprises. The main job is to separate true positives from noise, decide whether the finding represents a real code-path exposure, and route it to the right owner while the change is still easy to correct. That is why the feedback loop matters more than the scanner itself. When teams make the review process fast and consistent, they reduce the chance that insecure patterns become normalised in the codebase.

GitHub’s guidance on code scanning is useful here because it frames findings as part of developer workflow rather than as a separate security queue. In practice, many security teams encounter the real weakness only after repeated reviewer fatigue has already taught developers to ignore the alert.

What Good Triage Looks Like Before Merge

The first decision is whether the finding is exploitable, explainable, or clearly out of scope for the change. Teams should confirm the affected path, review whether the issue is reachable from the current diff, and check whether compensating controls already reduce the practical risk. A finding that is theoretical but not reachable may still deserve backlog tracking, but it should not block every pull request in the same way as an immediately exploitable flaw.

  • Prioritise findings that affect authentication, input handling, secret handling, injection paths, or unsafe deserialisation.
  • Assign fixes to the code owner or service owner who can verify the intended behaviour.
  • Use the pull request discussion to clarify whether the issue is a bug, an accepted exception, or a false positive.
  • Require retesting or rescanning after the code change so the original alert is closed on evidence, not assumption.

OWASP’s guidance on the OWASP Non-Human Identity Top 10 is relevant when PR findings involve leaked tokens, hard-coded secrets, or automation credentials, because those issues can turn a routine code review into a credential-exposure problem with broader blast radius.

The workflow breaks down when teams treat all findings as equally urgent, because that usually creates queue buildup, delayed reviews, and pressure to approve code without real remediation.

When Pull Request Findings Become Process Problems

Tighter pre-merge review often improves security, but it also increases friction, so teams must balance protection against developer throughput. The tradeoff is not simply speed versus safety; it is whether the organisation can enforce meaningful review without creating so much noise that engineers bypass the control or disable it for convenience.

There is still no universal consensus on the best acceptance threshold for SAST in every repository. Mature teams usually adapt the handling model to the codebase: high-risk services get stricter gating, while low-risk changes may rely on documented exceptions, time-boxed fixes, or manual approval from a trusted owner. The important point is consistency. If the same class of finding is sometimes blocked and sometimes ignored, developers will learn that the policy is negotiable rather than risk-based.

Where automated checks are tied to branch protection, teams should be careful not to confuse scanner status with remediation status. A green pipeline only means the current PR has no open blocking issues, not that the broader application is secure. That distinction matters most in large repositories, where old findings, reused libraries, or shared components can make one pull request appear safer than the system actually is.

Practitioner takeaway: teams get the best result when they use PR and MR SAST feedback to drive fast ownership and evidence-based decisions, not to create a permanent approval bottleneck.

Standards & Framework Alignment

This section maps relevant standards and security frameworks to the operational risks and controls described in this guidance.

MITRE ATT&CK address the attack and risk surface, while CIS Controls v8 and NIST CSF 2.0 set the governance and control requirements practitioners need to meet.

Framework Control / Reference Relevance
CIS Controls v8 03 — Data Protection SAST findings often reveal code paths that expose sensitive data or secrets.
04 — Secure Configuration of Enterprise Assets and Software Merge-request gates are a control point for enforcing secure code and build settings.
08 — Audit Log Management PR findings need traceable review, ownership, and evidence of closure.
Recommendation — Use CIS Control 3 to catch and limit code patterns that expose sensitive data. Apply CIS Control 4 to block insecure defaults before code reaches main branches. Use CIS Control 8 to retain review evidence and close findings with traceability.
MITRE ATT&CK T1059 — Command and Scripting Interpreter PR scanning commonly flags code paths that enable execution of unsafe input or commands.
Recommendation — Map unsafe execution paths to T1059 and review for command injection exposure.
NIST CSF 2.0 PR.IP-1 — Information Protection Processes and Procedures SAST triage belongs in documented secure development and review procedures.
Recommendation — Embed PR triage rules in PR.IP-1 so findings are handled consistently before merge.